pjfanning commented on PR #103: URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/103#issuecomment-1632440763
> > We're getting -1s in votes. Provide too much information, no -1. Provide too little, we get -1. I'm erring on the side of maximising the chances of getting releases approved. > > I understand the context and I am not saying we shouldn't do anything and/or provide less info (the header obviously needs to be there). Its just that some of the current info we are providing language wise seems wrong, i.e. with the current `license header from` text it sounds like we are taking the header from other source which legally speaking is a no no (you never "take" headers from another source, the headers are coupled with source code and you automatically bring it over). > > EDIT: To put this another away, I have never seen comments pertaining to "header coming from/taken from x" and if I actually see that text rather than being legally helpful it has the other effect of raining red flags. For me, it is equally confusing to have so many license headers without providing some context as to why we have so many - including 2 separate Apache headers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
