pjfanning commented on PR #103: URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/103#issuecomment-1632529751
> > I have not seen any rules that forbid us from adding informational comments around the license headers to help users understand why they are there. > > Thats not the issue, my concern is that when someone with no context looks at this file, even with the clarifying comment, it looks incredibly suspicious because in essence we have duplicated headers. Our bespoke ASF header is meant to grant the same effect as the standard ASF header + including a note that it was derived from Akka **and** yet we have another standard ASF header (due to it being based on code from Apache Kafka) because....? > > Isn't a much better solution just modifying our bespoke ASF header to > > ```scala > /* > * Licensed to the Apache Software Foundation (ASF) under one or more > * license agreements; and to You under the Apache License, version 2.0: > * > * https://www.apache.org/licenses/LICENSE-2.0 > * > * This file is part of the Apache Pekko project, which was derived from Akka > * and Apache Kafka https://github.com/apache/kafka/blob/451fff8937c626a187371b8fcdf50cfb5177d38f/clients/src/main/java/org/apache/kafka/clients/producer/internals/DefaultPartitioner.java > */ > ``` > > (note the `and Apache Kafka` part at the end). Its clear, provides just as much info and most critically doesn't look suspect. You can even specify the full filename if you want, i.e. > > ```scala > /* > * Licensed to the Apache Software Foundation (ASF) under one or more > * license agreements; and to You under the Apache License, version 2.0: > * > * https://www.apache.org/licenses/LICENSE-2.0 > * > * This file is part of the Apache Pekko project, which was derived from Akka > * and Apache Kafka (specifically > * https://github.com/apache/kafka/blob/451fff8937c626a187371b8fcdf50cfb5177d38f/clients/src/main/java/org/apache/kafka/clients/producer/internals/DefaultPartitioner.java) > */ > ``` Could you raise an issue in the LEGAL Jira project for this? https://issues.apache.org/jira/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
