ptrdom commented on code in PR #523:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/523#discussion_r4370920362
##########
.github/workflows/build-test.yml:
##########
@@ -210,10 +258,11 @@ jobs:
test-mysql:
name: Run tests with MySQL
+ needs: scala-versions
runs-on: ubuntu-latest
strategy:
matrix:
- SCALA_VERSION: [ scala213, scala3, scala3Lts, scala3Next ]
+ SCALA_VERSION: ${{ fromJson(needs.scala-versions.outputs.versions) }}
Review Comment:
Agreed, changed in e36dbe0. Scala 3.9 and 3.10 now only go through "Test and
compile" (`test:compile`, so main and test sources), nightly and on PRs that
bump them. The PostgreSQL, PostgreSQL JSONB, YugabyteDB and MySQL jobs only run
for 2.13 and 3.3, and they and Docs are skipped on the nightly schedule. Almost
all specs need a database today, so I left unit tests out for 3.9/3.10; once
#517 is merged, the H2 tests can be added to that job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
