pjfanning commented on code in PR #523:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/523#discussion_r4370916153
##########
.github/workflows/build-test.yml:
##########
@@ -210,10 +258,11 @@ jobs:
test-mysql:
name: Run tests with MySQL
+ needs: scala-versions
runs-on: ubuntu-latest
strategy:
matrix:
- SCALA_VERSION: [ scala213, scala3, scala3Lts, scala3Next ]
+ SCALA_VERSION: ${{ fromJson(needs.scala-versions.outputs.versions) }}
Review Comment:
I'm not convinced that we need to integration test with scala 3.9/3.10 - I
think compilation and unit tests, even h2 integration testing when the h2
support PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
