thunguo commented on code in PR #1061:
URL:
https://github.com/apache/incubator-seata-go/pull/1061#discussion_r2910437971
##########
pkg/datasource/sql/tx.go:
##########
@@ -96,11 +96,25 @@ func withTxCtx(ctx *types.TransactionContext) txOption {
}
}
+// withXAConn
+func withXAConn(xaConn interface {
Review Comment:
```go
xaConn interface {
Commit(ctx context.Context) error
Rollback(ctx context.Context) error
}
```
The readability here isn't very good, shouldn't this type be abstracted out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
