AlexStocks commented on code in PR #1061:
URL:
https://github.com/apache/incubator-seata-go/pull/1061#discussion_r3004223390
##########
pkg/datasource/sql/conn_xa.go:
##########
@@ -51,6 +51,18 @@ type XAConn struct {
isConnKept bool
}
+// xaBranchTx satisfies database/sql's transaction contract while XA branch
+// lifecycle is driven by XA START/END/PREPARE on the connection itself.
+type xaBranchTx struct{}
+
+func (xaBranchTx) Commit() error {
Review Comment:
[P0] xaBranchTx 空实现违反 XA 语义。Commit/Rollback 返回 nil
但不执行任何操作，可能导致数据不一致。建议返回明确错误或记录警告日志。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
