AlexStocks commented on code in PR #1061:
URL:
https://github.com/apache/incubator-seata-go/pull/1061#discussion_r3004223826
##########
pkg/datasource/sql/conn_xa.go:
##########
@@ -128,11 +140,18 @@ func (c *XAConn) BeginTx(ctx context.Context, opts
driver.TxOptions) (driver.Tx,
c.txCtx.XID = tm.GetXID(ctx)
c.txCtx.TransactionMode = types.XAMode
- tx, err := c.Conn.BeginTx(ctx, opts)
+ branchTx := xaBranchTx{}
Review Comment:
[P1] newTx 参数传递 branchTx 作为 originTx，branchTx 是空实现，后续调用 tx.target.Rollback()
会无操作。建议明确注释说明这是有意设计。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
