AlexStocks commented on code in PR #1061:
URL:
https://github.com/apache/incubator-seata-go/pull/1061#discussion_r2992659274
##########
pkg/datasource/sql/xa_resource_manager.go:
##########
@@ -197,7 +197,7 @@ func (xaManager *XAResourceManager) BranchRollback(ctx
context.Context, branchRe
}
func (xaManager *XAResourceManager) LockQuery(ctx context.Context, param
rm.LockQueryParam) (bool, error) {
- return false, nil
+ return xaManager.rmRemoting.LockQuery(param)
Review Comment:
[P1] LockQuery 这里从固定返回值改成真实透传远端调用，行为已经发生变化，但当前 PR 没有对应单测覆盖 rue/false 结果和
error 透传。这个接口直接参与全局锁检查，一旦 remoting 层参数或返回语义回归，这里会静默失效。建议至少补两类测试：1)
远端返回可加锁/不可加锁时原样透传；2) 远端返回 error 时 error 不被吞掉。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
