RaigorJiang commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703758568
##########
parser/sql/dialect/doris/pom.xml:
##########
@@ -36,5 +36,11 @@
<artifactId>shardingsphere-infra-database-doris</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <scope>test</scope>
Review Comment:
@linghengqian Yes, I found the difference, in this PR you removed logback
from the root pom and added it to specific modules, just to make logback not
appear in the test scope downstream?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
