ccxxxyy commented on PR #37831:
URL: https://github.com/apache/shardingsphere/pull/37831#issuecomment-3804975740
@terrymanu Hi! Thank you for your guidance! I hope my revisions can meet the
requirements. Hope you can review them when you have time.
1. In
parser/sql/engine/core/src/main/java/org/apache/shardingsphere/sql/parser/engine/core/database/visitor/SQLVisitorRule.java,
DORIS_DROP_MATERIALIZED_VIEW ("DropMaterializedView", SQLStatementType.DDL)
has been added at line 218,
DORIS_ALTER_MATERIALIZED_VIEW ("DorisAlterMaterializedView",
SQLStatementType.DDL) has been added at line 216, and
SHOW_VIEW ("ShowView", SQLStatementType.DAL) has been added at line 234.
As a result, the naming has been corrected and the missing rules have been
added.
2. For MaterializedViewColumnSegment, the implementation has been completed.
The corresponding methods in DorisDDLStatementVisitor.java have been
enhanced, and the assertions in
test/it/parser/src/main/resources/case/ddl/create-materialized-view.xml have
been completed accordingly.
3. The processScheduleTrigger and processAlterMVRefreshTrigger methods in
DorisDDLStatementVisitor.java have been modified.
The implementations of DorisAlterMaterializedViewStatement and
DorisCreateMaterializedViewStatement, along with their corresponding Assert
classes and TestCase classes, have been completed.
Additionally, the assertions in
test/it/parser/src/main/resources/case/ddl/alter-materialized-view.xml and
test/it/parser/src/main/resources/case/ddl/create-materialized-view.xml have
been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
