ccxxxyy commented on PR #37831: URL: https://github.com/apache/shardingsphere/pull/37831#issuecomment-3814572451
@terrymanu Thanks very much for your reply and guidance! I sincerely hope you could review my latest changes when you have some time. 1. **Regarding dorisCreateMaterializedView** I have updated DDLStatement.g4 and DorisDDLStatementVisitor.java as requested. In addition, I have added assertion tests in case/ddl/create-materialized-view.xml and sql/supported/ddl/create-materialized-view.xml. 2. **Regarding DATE_TRUNC, MATERIALIZED, and PAUSE** My understanding is that by adding them to the **identifierKeywordsUnambiguous** in BaseRule.g4, they can be used in places where identifiers are expected. My reasoning is as follows: The identifier usage chain is: tableName → name → identifier columnName → identifier and **identifier** includes **identifierKeywordsUnambiguous**. This means that they can be used as identifiers such as table names, column names, and database names without requiring quotation marks. In a previous commit, I have added corresponding test cases to verify this behavior in: case/ddl/create-table.xml case/dml/select.xml case/dml/update.xml as well as the related files under sql/supported/ddl. 3. **About the scope of this PR** This PR is intentionally scoped as parser-only support. I have clarified this scope explicitly in this PR description and document the known limitation that these statements are not executable yet. Thanks again for your time, review, and valuable guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
