ccxxxyy commented on PR #37831: URL: https://github.com/apache/shardingsphere/pull/37831#issuecomment-3809097958
@terrymanu Thank you very much for your response. However, I still have some questions regarding these three points, and I would really appreciate it if you could take a look at my thoughts below. - About temporarily stopping the improvement of Doris CREATE VIEW syntax in this PR 1. I hope to temporarily stop improving the Doris CREATE VIEW syntax in this PR. The reason is that once we start fixing the syntax, we need to modify CreateViewStatement and the related assertion classes. However, this will cause issues in Hive SQL parsing, because Hive also references CreateViewStatement, the Hive assertion tests will fail. Therefore, in order to properly support the Doris CREATE VIEW syntax, we also need to modify HiveDDLStatementVisitor.java. However, in your previous reply, you suggested rolling back the Hive-related changes and keeping this PR focused only on Doris. This means I must also roll back the changes to CreateViewStatement and the assertion classes; otherwise, the Hive assertion tests will fail and this PR cannot move forward at all. 2. For this reason, before submitting a separate PR to improve Hive parsing, it is not feasible to improve the Doris CREATE VIEW syntax in the current PR. In other words, only after the Hive syntax is improved can we safely proceed with improving the Doris CREATE VIEW syntax. Since both Hive and Doris reference CreateViewStatement, conflicts will inevitably occur between them. 3. Based on this consideration, I propose that this PR should temporarily not include improvements to the Doris CREATE VIEW syntax. - About the SHOW VIEW syntax According to the [official documentation](https://doris.apache.org/docs/4.x/sql-manual/sql-statements/table-and-view/view/SHOW-VIEW), the SHOW VIEW syntax is defined as: SHOW VIEW { FROM | IN } table [ FROM db ] In my implementation in DALStatement, it is defined as: SHOW VIEW fromTable fromDatabase? I am confused about the syntax you mentioned: SHOW VIEW FROM [LIKE pattern]; Could you please let me know the source of this syntax definition - About adding Doris bind logic 1. I am also confused about whether Doris-specific binder logic should be added. In a previous [PR ](https://github.com/apache/shardingsphere/pull/37588) I mentioned (https://github.com/apache/shardingsphere/pull/37588 ), the last reply from a Member stated: "Can you remove the doris bind logic? This does not conform to the current design; the SQL Bind module does not care about specific dialects and only processes SQLStatement." 2. Based on this feedback, I would like to better understand whether adding Doris bind logic is consistent with the current design. I am genuinely unsure whether a binder should be added. If it is indeed necessary, I would greatly appreciate your guidance on how it should be done. I sincerely look forward to your reply and guidance. Thank you again for your time and effort! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
