ccxxxyy commented on PR #37831:
URL: https://github.com/apache/shardingsphere/pull/37831#issuecomment-3822325334
@terrymanu Hello, thank you for your reply. I am quite confused by the three
points you mentioned, and I would be very grateful if you could take some time
to respond and help clarify my concerns so that I can move this PR forward.
**First**, I am very confused about the issues you mentioned in points 1 and
2 regarding the DROP VIEW / SHOW VIEW syntax in SQLVisitorRule.java. In the
current version of SQLVisitorRule.java, line 218 defines
**DORIS_DROP_MATERIALIZED_VIEW("DropMaterializedView", SQLStatementType.DDL)**
and line 234 defines **SHOW_VIEW("ShowView", SQLStatementType.DAL)**
Support for these has already been added in the earlier commit. Therefore, I
am confused about the problems mentioned in your first two points. Could you
please take a look at the latest version of SQLVisitorRule.java and let me know
whether the current definitions at line 218
(DORIS_DROP_MATERIALIZED_VIEW("DropMaterializedView", SQLStatementType.DDL))
and line 234 (SHOW_VIEW("ShowView", SQLStatementType.DAL)) meet the requirements
**Second**, regarding the **CREATE VIEW** syntax, I sincerely and
respectfully hope that this PR does not involve further improvements to the
CREATE VIEW syntax. I have already removed the reference to CREATE VIEW from
the PR description.
Originally, I intended to improve the CREATE VIEW syntax in this PR.
However, once CreateViewStatement is modified, HiveDDLStatementVisitor, which
also references CreateViewStatement, must be modified at the same time. Since
you suggested that this PR should remain focused on Doris,
HiveDDLStatementVisitor has to be reverted to its original state. In order to
avoid causing failures in the Hive tests that also rely on CreateViewStatement,
CreateViewStatement itself cannot be modified in this PR.
Therefore, I would like to propose the following approach: after this PR is
merged, I will first submit a separate PR to address the issues in
HiveDDLStatementVisitor, and only after that will I submit another PR to
improve the assertions.
I have explained this request in detail in previous replies as well. I
sincerely hope that, for this PR, we can avoid modifying CreateViewStatement
and the related assertion classes. Once the issues in HiveDDLStatementVisitor
are resolved, I will improve the CREATE VIEW syntax and assertions in a
dedicated PR. I truly hope this request can be accepted!
Thanks again for taking the time to respond to my concerns and respectfully
hope. Looking forward to your reply!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
