SankeerthNara commented on issue #31503: URL: https://github.com/apache/shardingsphere/issues/31503#issuecomment-5351774227
Hi @terrymanu @iamhucong, Went through the full task list on this issue and everything appears resolved now: ALTER SYSTEM ADD/DROP FOLLOWER/OBSERVER — merged via #37552 RECOVER DATABASE/TABLE/PARTITION (all variants, with and without <id>/AS <new_name>) — merged via #39512 array_cum_sum(Array<T>) — no code changes needed. Verified by parsing all four example cases from the [official docs](https://doris.apache.org/docs/2.1/sql-manual/sql-functions/scalar-functions/array-functions/array-cum-sum/) against current master using the ANTLR grammar directly: SELECT array_cum_sum(int_array) FROM array_cum_sum_test; SELECT array_cum_sum(double_array) FROM array_cum_sum_test; SELECT array_cum_sum(['a', 1, 'b', 2, 'c', 3]); The accompanying CREATE TABLE array_cum_sum_test (...) setup statement All four parse cleanly — array_cum_sum falls through the existing generic completeRegularFunction → regularFunctionName → identifier path, and array literals are already handled by the existing arrayExpression rule. No grammar, visitor, or test changes required (per this issue's own note: "If a SQL case can be executed successfully without any code changes, there is no need to add a corresponding test assert file"). I don't see any remaining scope from the original task list. Would it be OK to close this one out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
