terrymanu commented on issue #31473: URL: https://github.com/apache/shardingsphere/issues/31473#issuecomment-5385979524
Hi @iamhucong, thanks for raising this. I verified the remaining 5 unchecked cases on the current master; all of them are already supported, so no code change is needed: 1. `CREATE TABLE windowfunnel_test (...) DUPLICATE KEY(xwho) DISTRIBUTED BY HASH(xwho) BUCKETS 3 PROPERTIES (...)` parses and visits to `CreateTableStatement` — the Doris-specific clauses already exist in `DDLStatement.g4` (`duplicatekeyClause`, `distributedbyClause`, `propertiesClause`). 2. `INSERT INTO windowfunnel_test (...) VALUES (...), (...)` parses to `InsertStatement`. 3. `WINDOW,FUNCTION,WINDOW_FUNNEL` is a scraping artifact rather than executable SQL. The documented usage `window_funnel(window, mode, timestamp, cond1, ...)`, both the aggregate form and the `OVER ()` window form, parses fine since non-keyword function names fall back to `identifier` in `regularFunctionName`. 4. `BITAND` — same as above; `SELECT bitand(3, 5)` parses fine. 5. `DROP FUNCTION my_add(INT, INT)` was already fixed by #38108, which also added the parser IT case `drop_function_with_params_doris` with the same SQL. All 10 cases in this issue are now covered, so I'm closing it. Thanks for everyone's contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
