terrymanu commented on issue #31475:
URL:
https://github.com/apache/shardingsphere/issues/31475#issuecomment-5385989674
Hi @iamhucong, thanks for reporting this.
All four remaining cases are already supported by the current Doris SQL
parser, so this issue can be closed as completed. Verified each SQL below with
the Doris dialect through `SQLParserEngine` + `SQLStatementVisitorEngine` on
the latest master:
- `SELECT row_number() OVER (ORDER BY date_and_time) AS id, c1, c2, c3, c4
FROM events` parses successfully.
- Window frame clauses `ROWS BETWEEN {m | UNBOUNDED} PRECEDING / CURRENT ROW
AND CURRENT ROW / {UNBOUNDED | n} FOLLOWING`, including the single-bound `ROWS
<bound>` form, all parse successfully.
- Named windows `ROW_NUMBER() OVER w ... WINDOW w AS (...)` parse
successfully. Note that a bare alias like `AS row_number` is rejected because
`ROW_NUMBER` is a reserved word, consistent with MySQL 8.0+ behavior; use a
quoted alias such as `AS 'row_number'` instead.
- `SELECT bitmap_and_count(bitmap_from_string('1,2,3'),bitmap_empty())`
parses successfully via the generic function path.
These paths are already covered by parser IT cases `select_window`,
`select_window_frame_doris`, `select_window_last_value_doris` (#37673, #38392)
and `select_bitmap_intersect_doris`,
`select_bitmap_to_string_with_bitmap_intersect_doris` (#39573). The first six
items were fixed by #38086 and #38101.
I have ticked the remaining checkboxes and will close this issue as
completed. Thanks for everyone's contributions on the Doris parsing series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
