terrymanu commented on issue #31477:
URL:
https://github.com/apache/shardingsphere/issues/31477#issuecomment-5384078228
Hi @iamhucong, thanks for initiating this Doris SQL parsing tracking issue.
We have verified all the remaining unchecked cases against the current master,
and each one is either already supported or an invalid scraped fragment, so
this issue can be closed as completed.
**Already supported (verified with the current Doris parser):**
- `select null_or_empty(null)` parses successfully. Any regular identifier
is accepted as a function name by `regularFunctionName` in `BaseRule.g4` of the
Doris dialect, and `NULL` is a valid argument literal.
- `ALTER SQL_BLOCK_RULE test_rule PROPERTIES("sql"="select \\* from
test_table","enable"="true")` was already covered by PR #37817, which added the
identical sql-case `alter_sql_block_rule_with_sql` with its assertion in the
parser test resources. This checkbox was simply not ticked.
- The `SELECT ... INTO OUTFILE ... FORMAT AS ...` syntax is already
supported by the Doris `DMLStatement.g4` grammar, and `SHOW ROUTINE LOAD TASK`
was also implemented in PR #37817.
**Invalid fragments produced by the web scraper (not SQL statements):**
- `DATE` — a type name extracted from the DATE data-type documentation page.
- The `TaskId: ... TxnStatus: UNKNOWN ...` block — output of `SHOW ROUTINE
LOAD TASK`, not a statement itself.
- `The final filename will consist of ...` — documentation prose from the
OUTFILE page.
- `FORMAT AS CSV` — a clause fragment of `OUTFILE`, not a standalone
statement.
Since every remaining case is either already supported or not valid SQL, no
further code change is required. We are closing this issue as completed. Thanks
again to everyone who contributed to Doris SQL parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
