Aias00 commented on PR #7749: URL: https://github.com/apache/shenyu/pull/7749#issuecomment-6367070186
Approved, but the checks are red on a shared e2e case rather than on this change. `build (shenyu-integrated-test-http)` fails in `CachePluginTest`, and it is not caused by this PR: ``` [ERROR] CachePluginTest.testMemoryModle:54 expected: <true> but was: <false> [ERROR] CachePluginTest.testRedisModle:73 expected: <true> but was: <false> [ERROR] Tests run: 103, Failures: 2, Errors: 0, Skipped: 5 ``` The same two cases are red on every other PR that touches this module right now, so this is the shared e2e case rather than your change. `build` is only an aggregate gate, so a single shared case turns the whole check red. Could you keep this rebased and re-run once the http e2e case is fixed upstream? Nothing else blocks my approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
