wu-sheng commented on a change in pull request #1213: provides a
optional-plugin for tracking ignores enhancement(#1203)
URL:
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187882858
##########
File path: apm-sniffer/optional-plugins/pom.xml
##########
@@ -98,11 +102,22 @@
<configuration>
<tasks>
<taskdef
resource="net/sf/antcontrib/antcontrib.properties"
classpathref="maven.runtime.classpath" />
+ <mkdir
dir="${optional.agent.package.dest.dir}" />
<if>
<equals arg1="${project.packaging}"
arg2="jar" />
<then>
- <mkdir dir="${plugin.dest.dir}" />
- <copy
file="${project.build.directory}/${project.artifactId}-${project.version}.jar"
tofile="${plugin.dest.dir}/${project.artifactId}-${project.version}.jar"
overwrite="true" />
+ <if>
+ <!-- if the plugin is a directory
-->
Review comment:
I am wondering, whether be better if put conf and jar in the
`optional-plugins` dictionary directly? I feel strange about this part. Or do
you have any suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
