wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187879656
########## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-annotation-plugin/pom.xml ########## @@ -28,6 +28,10 @@ <artifactId>apm-spring-annotation-plugin</artifactId> + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <sdk.plugin.related.dir>/..</sdk.plugin.related.dir> Review comment: This could be the default in `optional-plugins/pom.xml`, which will make people easier to understand. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services