wu-sheng commented on pull request #7554: URL: https://github.com/apache/skywalking/pull/7554#issuecomment-907642003
One key principle you are still not 100% following Only expose necessary methods to usage. All complex things(especially fail back) should be kept in one place and internally. Logic should belong to its owner. API(Watcher's API) users don't care or don't want to care how these threshold(rate/duration) gets initialization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
