wu-sheng commented on pull request #7554: URL: https://github.com/apache/skywalking/pull/7554#issuecomment-907741567
> > > `don't need to keep moduleConfig, just pass the file path into #loadDefaultPolicy enough.` > > > So we should have another `variable` to keep `file path`? Because it will need to load static configs from the file, when `traceSamplingPolicy` been deleted dynamically. > > > > > > Don't keep the file path, or read it again. Keeping the content should be enough. > > I'm still a little confused. How to keep the content? Keeping the file content in memory? If the file contains a lot of content that takes up unnecessary memory. Yes, keep the content, even the object instance representing the parsed result. Each service could only take 3 lines of settings, 200-300 services mean a less than 1000 lines file, which means nothing from memory perspective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
