HendSame commented on pull request #7554: URL: https://github.com/apache/skywalking/pull/7554#issuecomment-907644315
> I am so sorry that, I have to be so strict/rigorous about this PR. Because it is a big change for code structure. New sampling conditions/rules could be added by others in the future, and they will follow your code style. Like you did in other PRs for following older codes. > Once we make this part of codes not clear, it will make further review harder, and logic gets inconsistent. Eventually, we have to face unexpected bugs. Totally understand！I will update the points that you had proposed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
