wu-sheng commented on pull request #7554: URL: https://github.com/apache/skywalking/pull/7554#issuecomment-907642303
Watcher should expose at most 3 methods 1. `getPolicySetting` -> `PolicySetting`. 2. `PolicySetting#shouldSample(int rate)` 3. `PolicySetting#isOverSlowThreshold(int duration)`. All other things should be kept internally. And most logic should be written once. Such as `getPolicySetting` -> `PolicySetting` should include all fail back logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
