nisiyong commented on PR #397: URL: https://github.com/apache/skywalking-java/pull/397#issuecomment-1328071202
This PR I almost finish. Two more things I need to confirm: 1. Are you agree with the agent version format, like `8.14.0-2ef1977-221126`? 2. Now we could copy the version properties into source tarball, but it will compile failed because of the check style plugin, I think this file needs to be ignored. ``` [INFO] --- git-commit-id-plugin:4.9.10:revision (get-the-git-infos) @ apm-agent-core --- [INFO] [INFO] --- maven-checkstyle-plugin:3.1.0:check (validate) @ apm-agent-core --- [INFO] Starting audit... [ERROR] /private/tmp/apache-skywalking-java-agent-8.14.0-test/apm-sniffer/apm-agent-core/src/main/resources/skywalking-agent-version.properties:1: Missing a header - not enough lines in file. [RegexpHeader] Audit done. [INFO] There is 1 error reported by Checkstyle 8.19 with /tmp/apache-skywalking-java-agent-8.14.0-test/apm-checkstyle/checkStyle.xml ruleset. [ERROR] src/main/resources/skywalking-agent-version.properties:[1] (header) RegexpHeader: Missing a header - not enough lines in file. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for java-agent 8.14.0-SNAPSHOT: [INFO] [INFO] java-agent ......................................... SUCCESS [ 2.242 s] [INFO] java-agent-commons ................................. SUCCESS [ 0.126 s] [INFO] apm-util ........................................... SUCCESS [ 2.625 s] [INFO] java-agent-datacarrier ............................. SUCCESS [ 2.314 s] [INFO] java-agent-protocol ................................ SUCCESS [ 0.057 s] [INFO] java-agent-network ................................. SUCCESS [ 6.497 s] [INFO] java-agent-sniffer ................................. SUCCESS [ 0.048 s] [INFO] apm-agent-core ..................................... FAILURE [ 3.636 s] [INFO] apm-agent .......................................... SKIPPED [INFO] apm-test-tools ..................................... SKIPPED [INFO] apm-sdk-plugin ..................................... SKIPPED [INFO] rabbitmq-plugin .................................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18.280 s [INFO] Finished at: 2022-11-26T23:52:41+08:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project apm-agent-core: You have 1 Checkstyle violation. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :apm-agent-core ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
