nisiyong commented on PR #397: URL: https://github.com/apache/skywalking-java/pull/397#issuecomment-1328176105
> 2\. The OAP used a similar way, but the last part(date) is not updated properly. @wu-sheng @kezhenxu94 Once the version properties file has been generated, the `git.build.time` indeed couldn't be overwritten unless this file was clean. I think the reason relates to this PR https://github.com/git-commit-id/git-commit-id-maven-plugin/pull/513. When we package the agent with `.git`, we run will run maven `clean` phrase first, this file will generate every time, so the `git.build.time` is the newest. I think it is okay, we can still keep it. When we package the agent from the source tarball, as the `git.build.time` couldn't be written, I think we could ignore this field if we haven't better solutions. We could remove the `git.build.time` line in the `create_release.sh` after the initialize, and the `Version#toString` could identify whether the build time is blank. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
