kezhenxu94 commented on code in PR #397: URL: https://github.com/apache/skywalking-java/pull/397#discussion_r1032855714
########## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/version/Version.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.agent.core.version; + +import lombok.Getter; + +import java.io.IOException; +import java.util.Properties; + +@Getter +public enum Version { + CURRENT; + + private static final String VERSION_FILE_NAME = "skywalking-agent-version.properties"; + private final String buildVersion; + private final String commitIdAbbrev; + private final String buildTime; Review Comment: Please read the link I pasted and the [related issue](https://github.com/apache/skywalking/issues/8887), I meant the build time doesn't work **as expected**, we expect the build time to change every time you build, but the build time just stays at the moment when you first build. In your log, `git.build.time=221126` is correct yesterday, but doesn't change some time in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
