nisiyong commented on PR #397: URL: https://github.com/apache/skywalking-java/pull/397#issuecomment-1328266242
> I think we should have two files, one for commit id, the other is for final version number. Then we could make sure the version suffix is correct. Could you explain more about why we need two files? This PR is finished, please consider this implementation. Now we could generate the agent version in the git repo scenario and the source tarball scenario. And the build time will be ignored when users build the agent from the source tarball. Here are the agent logs I tested. **1. Agent log, built from git repo** ``` INFO 2022-11-27 22:54:53.642 main Version : SkyWalking agent version: 8.14.0-SNAPSHOT-4166be4-20221127145403 ``` if we run `mvn clean package` to package the agent again, the build time is changed, the new agent log as follows: ``` INFO 2022-11-27 22:57:28.241 main Version : SkyWalking agent version: 8.14.0-SNAPSHOT-4166be4-20221127145649 ``` **2. Agent log, built from source tarball** Use the `create_release.sh` to package the source tarball. ``` INFO 2022-11-27 22:48:10.600 main Version : SkyWalking agent version: 8.14.0-SNAPSHOT-4166be4 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
