Alipebt commented on code in PR #103:
URL: https://github.com/apache/skywalking-go/pull/103#discussion_r1334324989
##########
plugins/grpc/instrument.go:
##########
@@ -67,6 +67,21 @@ func (i *Instrument) Points() []*instrument.Point {
instrument.WithResultType(0, "ClientStream")),
Interceptor: "ClientStreamingInterceptor",
},
+ {
+ PackagePath: "",
+ At: instrument.NewMethodEnhance("*ClientConnInterface",
"Invoke",
Review Comment:
The interface cannot be intercepted, and I think intercepting
`ClientConnInterface` is not effective.
`ClientConn` implements this interface, and when user make RPC calls, the
Invoke and `NewStream` methods implemented by `ClientConn` are executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
