wu-sheng commented on code in PR #103:
URL: https://github.com/apache/skywalking-go/pull/103#discussion_r1335561454
##########
plugins/grpc/instrument.go:
##########
@@ -67,6 +67,21 @@ func (i *Instrument) Points() []*instrument.Point {
instrument.WithResultType(0, "ClientStream")),
Interceptor: "ClientStreamingInterceptor",
},
+ {
+ PackagePath: "",
+ At: instrument.NewMethodEnhance("*ClientConnInterface",
"Invoke",
Review Comment:
> By the way, I didn't find a way to control if sending the data to SK
server or not
No, you can't. That is kernel responsibility, including connection
management, TLS, traffic limitation, etc.
> For some use cases (at least in my cas), SkyWalking is not required for
the installation
What do you mean some cases? Do you mean some URL or protocol? Or something
else? You want to compile the agent into your binary, but not using it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
