wu-sheng commented on code in PR #103:
URL: https://github.com/apache/skywalking-go/pull/103#discussion_r1334349474
##########
plugins/grpc/instrument.go:
##########
@@ -67,6 +67,21 @@ func (i *Instrument) Points() []*instrument.Point {
instrument.WithResultType(0, "ClientStream")),
Interceptor: "ClientStreamingInterceptor",
},
+ {
+ PackagePath: "",
+ At: instrument.NewMethodEnhance("*ClientConnInterface",
"Invoke",
Review Comment:
If you mean you need more intercepting points to support more gRPC usage,
that is good.
You need to update the tests accordingly, with new usage of the gRPC APIs,
and new expected segments/spans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
