LinuxSuRen commented on code in PR #103:
URL: https://github.com/apache/skywalking-go/pull/103#discussion_r1335539933
##########
plugins/grpc/instrument.go:
##########
@@ -67,6 +67,21 @@ func (i *Instrument) Points() []*instrument.Point {
instrument.WithResultType(0, "ClientStream")),
Interceptor: "ClientStreamingInterceptor",
},
+ {
+ PackagePath: "",
+ At: instrument.NewMethodEnhance("*ClientConnInterface",
"Invoke",
Review Comment:
I feel very confused. The e2e test seem correct, but it cannot work in my
case. So, I tend to close this PR until I can figure it out.
By the way, I didn't find a way to control if sending the data to SK server
or not. For some use cases (at least in my cas), SkyWalking is not required for
the installation. So, I'm wonderfing if there is a way to control it.
I found a possible solution is that. Read an environment variable
`SW_AGENT_ENABLED`, return `false` if its value is `false`.
https://github.com/apache/skywalking-go/blob/b3e0cf3c66e3a4d9010d050b6a2015c4014b8a33/tools/go-agent/instrument/reporter/instrument.go#L47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
