dmsolr commented on a change in pull request #4236: Optimize the
elasticsearch-based query interface provided to UI
URL: https://github.com/apache/skywalking/pull/4236#discussion_r367798768
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/DurationUtils.java
##########
@@ -216,4 +216,59 @@ private DateTime parseToDateTime(Downsampling
downsampling, long time) throws Pa
return dateTime;
}
+
+ public long convertBucketTotIimestamp(boolean isStart, long bucket) throws
ParseException {
Review comment:
I see TB means TimeBucket and its form.
I am confused about why we need to uniform them. The form(TB/TS) is not
determined by the storage layer. So you covert the TB to TS on write and covert
it again on the query.
In other words, whether ES depends on TS. (Maybe I miss something.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
