wu-sheng commented on a change in pull request #4236: Optimize the
elasticsearch-based query interface provided to UI
URL: https://github.com/apache/skywalking/pull/4236#discussion_r367921235
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/DurationUtils.java
##########
@@ -216,4 +216,59 @@ private DateTime parseToDateTime(Downsampling
downsampling, long time) throws Pa
return dateTime;
}
+
+ public long convertBucketTotIimestamp(boolean isStart, long bucket) throws
ParseException {
Review comment:
First, timeBucket isn't in the format you are demonstrating. Then, I am not
talking who can put what codes in any place. My point is always being, put the
storage optimization codes inside the storage implementation. Don't change the
storage model interface unless you have to.
> why can't I put it into DurationUtils so that he can reuse this logic?
This question is really not a good way to discuss the question. I hope you
wouldn't do this again. The things we discussed is not about whom, @dmsolr is
showing something he is working on, his PR is in the WIP status, no
review/merge.
Also, you should understand, as an official committer, he actually really
has some privileges to change APIs, it could be easier than you. Because he has
been involved in source codes level a long time, and be familiar with the
workflow (You could simply check his GitHub repo changelog). But, even there is
a privilege, back to this case, I or he never use this priority. So, being an
open source project, please don't consider discussion(arguing between you and
others) in this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
