lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473843990
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
##########
@@ -40,7 +42,7 @@
* The <code>SnifferConfigInitializer</code> initializes all configs in
several way.
*/
public class SnifferConfigInitializer {
- private static final ILog logger =
LogManager.getLogger(SnifferConfigInitializer.class);
+ private static ILog LOGGER =
LogManager.getLogger(SnifferConfigInitializer.class);
Review comment:
> Then, I have a feeling, this PR should be after the all `logger` and
the exception rule to be removed. I don't want the codes with 2 style logger.
Agree. I have reverted the styles, just wait for the polish of the
style-check rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
