lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473916229
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -259,6 +266,43 @@
* @see
org.apache.skywalking.apm.agent.core.logging.core.PatternLogger#DEFAULT_CONVERTER_MAP
*/
public static String PATTERN = "%level %timestamp %thread %class :
%msg %throwable";
+
+ public static class JSON {
+ /**
+ * Key of the AgentName
+ */
+ public static String AGENT_NAME_KEY = "agent_name";
+
+ /**
+ * Key of the timestamp
+ */
+ public static String TIMESTAMP_KEY = "@timestamp";
Review comment:
> Why we need to adopt logstash?
I suppose it would be better to comply to the conventions which are common
used by others?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
