lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473914883
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
##########
@@ -40,7 +42,7 @@
* The <code>SnifferConfigInitializer</code> initializes all configs in
several way.
*/
public class SnifferConfigInitializer {
- private static final ILog logger =
LogManager.getLogger(SnifferConfigInitializer.class);
+ private static ILog LOGGER =
LogManager.getLogger(SnifferConfigInitializer.class);
Review comment:
> Would you like to do that first? I may not have time to do this
recently. You could remove the old exception rule, once style check passed, you
have changed all of them.
Sure. I can do this. Do you prefer a new PR with only rule changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
