lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473924290
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -259,6 +260,43 @@
* @see
org.apache.skywalking.apm.agent.core.logging.core.PatternLogger#DEFAULT_CONVERTER_MAP
*/
public static String PATTERN = "%level %timestamp %thread %class :
%msg %throwable";
+
+ public static class JSON {
+ /**
+ * Key of the AgentName
+ */
+ public static String AGENT_NAME_KEY = "agent_name";
Review comment:
> I think know why they are necessary. I prefer don't provide an
over-configurable feature. If someone wants it, they could add them by
providing a real use case.
I partially agree in the sense that some keys like `agent_name` are rarely
used by real application, so it can be just a constant (I can remove it).
But the others, for example the concepts of "@timestamp", "message", "class"
are also adopted by other logging framework. In order to simplify the
preference of collectors, I suppose it is necessary to just keep these
configurations here. They are very similar to what "pattern" does here.
I think the most users can keep the default settings like we always do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
