lujiajing1126 commented on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-677701149
> The `logger` related code style is here, > > https://github.com/apache/skywalking/blob/4e821415ea8b930d3c089346d86c650788cbbf8a/apm-checkstyle/checkStyle.xml#L82 > > . > It is not popular, but this is the legacy. We could change it all in another one PR, but don't mix it here. I just want to make sure what you meannt, whether the "|(^logger)" option should be removed from this legacy format, i.e. every `logger` should be rename to `LOGGER`. Or just declare `logger` as another exception of valid `StaticVariableName`s https://github.com/apache/skywalking/blob/4e821415ea8b930d3c089346d86c650788cbbf8a/apm-checkstyle/checkStyle.xml#L103 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
