wu-sheng commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473956466
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -259,6 +260,43 @@
* @see
org.apache.skywalking.apm.agent.core.logging.core.PatternLogger#DEFAULT_CONVERTER_MAP
*/
public static String PATTERN = "%level %timestamp %thread %class :
%msg %throwable";
+
+ public static class JSON {
+ /**
+ * Key of the AgentName
+ */
+ public static String AGENT_NAME_KEY = "agent_name";
Review comment:
> for example the concepts of "@timestamp", "message", "class" are also
adopted by other logging framework.
Please provide the official documentation. If they are there, we could adopt
it. But either way, still it is not necessary to make them configurable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
