wu-sheng commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473954782
##########
File path:
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -75,14 +84,14 @@ public static void premain(String agentArgs,
Instrumentation instrumentation) th
final ByteBuddy byteBuddy = new
ByteBuddy().with(TypeValidation.of(Config.Agent.IS_OPEN_DEBUGGING_CLASS));
AgentBuilder agentBuilder = new AgentBuilder.Default(byteBuddy).ignore(
- nameStartsWith("net.bytebuddy.").or(nameStartsWith("org.slf4j."))
- .or(nameStartsWith("org.groovy."))
- .or(nameContains("javassist"))
- .or(nameContains(".asm."))
- .or(nameContains(".reflectasm."))
- .or(nameStartsWith("sun.reflect"))
-
.or(allSkyWalkingAgentExcludeToolkit())
-
.or(ElementMatchers.isSynthetic()));
+
nameStartsWith("net.bytebuddy.").or(nameStartsWith("org.slf4j."))
Review comment:
This reformat seems very strange. Why do this? If you want to reformat,
this is a better choice.
```
AgentBuilder agentBuilder = new
AgentBuilder.Default(byteBuddy).ignore(
nameStartsWith("net.bytebuddy.")
.or(nameStartsWith("org.slf4j."))
.or(nameStartsWith("org.groovy."))
.or(nameContains("javassist"))
.or(nameContains(".asm."))
.or(nameContains(".reflectasm."))
.or(nameStartsWith("sun.reflect"))
.or(allSkyWalkingAgentExcludeToolkit())
.or(ElementMatchers.isSynthetic()));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
