mistercrunch commented on a change in pull request #5101: Explore to SQL Lab
URL:
https://github.com/apache/incubator-superset/pull/5101#discussion_r196297953
##########
File path: superset/assets/src/explore/components/DisplayQueryButton.jsx
##########
@@ -21,6 +25,7 @@ registerLanguage('json', json);
const $ = window.$ = require('jquery');
const propTypes = {
+ actions: PropTypes.object.isRequired,
Review comment:
(optional) I think the code has a fair amount of passing the whole `actions`
object around. I think it's preferable to pass something more generic when
possible to make the component more reusable and less bound to the app. Here
you could pass the `redirectSQLLab` action to an `onOpenInEditor` prop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
