mistercrunch commented on a change in pull request #5101: Explore to SQL Lab
URL:
https://github.com/apache/incubator-superset/pull/5101#discussion_r196298887
##########
File path: superset/connectors/base/models.py
##########
@@ -185,6 +191,8 @@ def data(self):
'metrics': [o.data for o in self.metrics],
'columns': [o.data for o in self.columns],
'verbose_map': verbose_map,
+ 'schema': self.schema,
+ 'select_star': self.select_star,
Review comment:
Given this here in the base class I'd go for a `pass` or `return None` in
`BaseDatasource.select_star`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
