mistercrunch commented on a change in pull request #5101: Explore to SQL Lab
URL:
https://github.com/apache/incubator-superset/pull/5101#discussion_r196298744
##########
File path: superset/connectors/base/models.py
##########
@@ -152,6 +152,12 @@ def short_data(self):
'creator': str(self.created_by),
}
+ @property
Review comment:
This method belongs in `connectors.sqla.models.SqlaTable` as Druid
datasources don't linke to `Database` but to cluster, this base should have a
`raise NotImplementedError()` or `pass`.
Also in that context you'll be able to simply use
`self.database.select_star(...)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
