mistercrunch commented on a change in pull request #5101: Explore to SQL Lab
URL:
https://github.com/apache/incubator-superset/pull/5101#discussion_r196298264
##########
File path:
superset/assets/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -211,6 +211,18 @@ export default class DatasourceControl extends
React.PureComponent {
/>
</a>
</OverlayTrigger>
+ {this.props.datasource.type === 'table' && <OverlayTrigger
Review comment:
nit (optional): personally I like to break before an incomplete tag as in
`\n<OverlayTrigger` but will defer on the linter here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
