villebro commented on pull request #15257: URL: https://github.com/apache/superset/pull/15257#issuecomment-864968724
> 2 more notes: > > 1. When user uncheck `Required` I think it shouldn't automatically uncheck `Filter has default value` checkbox, because user may be want to continue to work with it, just thoughts... It only unchecks "Filter has default value" when unchecking "Required" if the default value is empty. This is to avoid the case when checking and unchecking the "Required" checkbox, and being left with the default value picker expanded. > 2. If `Required` is unchecked should be selection of default value still required as on video in 11secs? Yes - this is in line with how it's done in the "Pre-filter values" section. @michael-s-molina can comment on this, I believe the idea is to validate that a default value really has been selected when checking the checkbox (it doesn't make sense to check "Filter has default value" and not seleect anything) . I added a tooltip to explain why the default value is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
