villebro commented on a change in pull request #15257:
URL: https://github.com/apache/superset/pull/15257#discussion_r655315964
##########
File path:
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -284,7 +284,7 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
extra={<Error>{filterState.validateMessage}</Error>}
>
<StyledSelect
- allowClear={!enableEmptyFilter}
+ allowClear
Review comment:
As we're already validating that the filter is set before letting the
user apply the filter selection, we no longer need to disable `allowClear`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
