villebro commented on pull request #15257: URL: https://github.com/apache/superset/pull/15257#issuecomment-865011010
> 1 functional question - when user selects a default value, should we disable "Default to first item" checkbox? Clicking that checkbox unchecks "Filter has default value" and clears the selection, which might be not what a user expects. WDYT? > @villebro I'm not sure if that's a problem or not, so I'm approving because the code looks good to me That's a good question. I'd almost suggest doing some functional guidelines for this type of automation and validation. When implementing these changes I noticed that while this automatic checking/unchecking/disabling feels mostly intuitive, I can't help but feel like the casual user might be overwhelmed by by checkbox 1 changing when checking checkbox 2 etc. Regarding your question, which is more intuitive/less unintuitive: Disabling "Default to first item" when selecting a value, or clearing the selection when checking "Default to first item"? I'm not sure which is better, but we should probably apply have some uniform reasoning behind these choices, as there's probably other similar cases that can confuse the user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
