kgabryje commented on pull request #15257: URL: https://github.com/apache/superset/pull/15257#issuecomment-865001426
1 functional question - when user selects a default value, should we disable "Default to first item" checkbox? Clicking that checkbox unchecks "Filter has default value" and clears the selection, which might be not what a user expects. WDYT? @villebro I'm not sure if that's a problem or not, so I'm approving because the code looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
