simcha90 commented on a change in pull request #15257:
URL: https://github.com/apache/superset/pull/15257#discussion_r655234850
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/CollapsibleControl.tsx
##########
@@ -78,7 +84,12 @@ const CollapsibleControl = (props: CollapsibleControlProps)
=> {
onChange(value);
}}
>
- {title}
+ <>
+ {title}{' '}
Review comment:
maybe better use ` ` instead ' '?
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -540,6 +555,20 @@ const FiltersConfigForm = (
const hasAdhoc = formFilter?.adhoc_filters?.length > 0;
+ const defaultToFirstItem = formFilter?.controlValues?.defaultToFirstItem;
+
+ useEffect(() => {
Review comment:
I think it's independent logic and we can move it to `state` file,
because this file already starts to be big
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
